Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): add controlled order & default order #220

Merged
merged 1 commit into from May 20, 2020
Merged

Conversation

ZxBing0066
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • Follow our contributing docs
  • Docs have been added/updated
  • Tests have been added; existing tests pass

Other information:

@ZxBing0066 ZxBing0066 self-assigned this May 20, 2020
@ZxBing0066 ZxBing0066 added the feature New feature or request label May 20, 2020
@ZxBing0066 ZxBing0066 added this to To do in Develop via automation May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #220 into master will increase coverage by 0.13%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   80.97%   81.11%   +0.13%     
==========================================
  Files         171      171              
  Lines        3512     3532      +20     
  Branches      814      851      +37     
==========================================
+ Hits         2844     2865      +21     
+ Misses        586      577       -9     
- Partials       82       90       +8     
Impacted Files Coverage Δ
src/components/Table/Table.jsx 81.21% <72.72%> (+1.45%) ⬆️
src/components/Input/Input.jsx 75.00% <0.00%> (ø)
src/components/Upload/Selector.jsx 11.11% <0.00%> (ø)
src/components/DatePicker/Range.jsx 52.50% <0.00%> (ø)
src/components/Table/ResizableTH.jsx 61.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c9d51...7029315. Read the comment docs.

@ZxBing0066 ZxBing0066 merged commit e71cb03 into master May 20, 2020
Develop automation moved this from To do to Done May 20, 2020
@ZxBing0066 ZxBing0066 deleted the table-order branch May 20, 2020 09:37
@ZxBing0066
Copy link
Contributor Author

close #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Develop
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant