Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav): fix selectedKeys bug when switch inlineCollapsed #391

Merged
merged 3 commits into from Mar 4, 2024

Conversation

nasnan
Copy link
Contributor

@nasnan nasnan commented Feb 22, 2024

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • Follow our contributing docs
  • Docs have been added/updated
  • Tests have been added; existing tests pass

Other information:

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.92%. Comparing base (dbccf32) to head (d9a9c4e).

Files Patch % Lines
src/components/Nav/NavItem.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   74.91%   74.92%           
=======================================
  Files         388      388           
  Lines       10005    10001    -4     
  Branches     2856     2853    -3     
=======================================
- Hits         7495     7493    -2     
+ Misses       2354     2352    -2     
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whilefor whilefor merged commit 108ee4b into UCloud-FE:master Mar 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants