Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node ids shouldn't have to be ints #62

Closed
fscottfoti opened this issue Mar 10, 2017 · 2 comments
Closed

node ids shouldn't have to be ints #62

fscottfoti opened this issue Mar 10, 2017 · 2 comments

Comments

@fscottfoti
Copy link
Contributor

It was recently discovered that node ids have to be ints with the current version. In practical terms this isn't a huge problem, but should probably be addressed at some point.

@kuanb
Copy link
Member

kuanb commented May 5, 2017

It'd be helpful if there was a warning of some sort when Pandana takes in a dataframe that has strings in its index. It "sort of" does right now because you will see it has removed all n of n edges, but an additional warning if all 100% of edges are removed, perhaps suggesting the user check and make sure that indexes are not strings might be a helpful one line modification and hint that would improve the debugging experience.

@fscottfoti fscottfoti mentioned this issue May 24, 2017
18 tasks
@fscottfoti
Copy link
Contributor Author

this is also fixed in #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants