Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify expression pass #21

Open
hanchenye opened this issue Dec 30, 2020 · 1 comment
Open

Simplify expression pass #21

hanchenye opened this issue Dec 30, 2020 · 1 comment
Labels
QoREstimation Transforms

Comments

@hanchenye
Copy link
Collaborator

Based on my experience, MLIR does not have passes to simplify things like this:

%cst_1 = 1.0 : f32
%1 = mulf %0, %cst_1 : f32

In this case, all uses of %1 can be replaced by %0. This simplification pass is meaningful for us because this is automatically simplified in Vivado HLS, which makes our estimator wrongly take some redundant mulf or other operations into consideration.
@mehank7 mehank7 mentioned this issue Apr 9, 2024
Open
@HahaLan97
Copy link

Isn't constant folding designed for this kind of simplification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QoREstimation Transforms
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanchenye @HahaLan97