Skip to content

Commit

Permalink
AMPI: MPICH test cases printing "No Errors"
Browse files Browse the repository at this point in the history
Following test cases never printed "No Errors" even if all the
test cases pass since it was printed after MPI_Finalize();

Change-Id: I114255dcbbbc8a54c1698494a81db1a03f8b00ad
  • Loading branch information
liquidmantle authored and evan-charmworks committed Feb 14, 2019
1 parent 399d909 commit 77f4440
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
3 changes: 2 additions & 1 deletion tests/ampi/mpich-test/coll/bcastzerotype.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ int main(int argc, char *argv[])
}

MPI_Type_free(&type);
MPI_Finalize();

if (wrank == 0) {
printf(" No errors\n");
}

MPI_Finalize();

return 0;
}
4 changes: 2 additions & 2 deletions tests/ampi/mpich-test/datatype/struct-ezhov.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ int main(int argc, char **argv)

MPI_Type_free(&struct_type);

MPI_Finalize();

printf(" No Errors\n");

MPI_Finalize();

return 0;
}
3 changes: 2 additions & 1 deletion tests/ampi/mpich-test/datatype/struct-verydeep.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,10 @@ int main(int argc, char **argv)
/*MPIDU_Datatype_debug(hdf5type, 32); */

MPI_Type_free(&hdf5type);
MPI_Finalize();

printf(" No Errors\n");

MPI_Finalize();

return 0;
}
3 changes: 2 additions & 1 deletion tests/ampi/mpich-test/pt2pt/sendflood.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,13 @@ int main(int argc, char *argv[])
if (verbose) {
fclose(pf);
}
MPI_Finalize();

/* This test fails if it hangs */
if (rank == 0) {
printf(" No Errors\n");
}

MPI_Finalize();

return 0;
}

0 comments on commit 77f4440

Please sign in to comment.