Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted search matches #186

Closed
joeedhorton opened this issue Sep 22, 2020 · 3 comments
Closed

Highlighted search matches #186

joeedhorton opened this issue Sep 22, 2020 · 3 comments
Labels
component help wanted Further context or research is needed to progress

Comments

@joeedhorton
Copy link
Contributor

joeedhorton commented Sep 22, 2020

What

Highlighting search matches helps users identify matching data.

Screenshot 2020-09-22 at 10 50 10

Why

We have removed this component from our design system for the following reasons:

  • no research has been conducted on this component in a live service
  • highlighted text is not highlighted to a screenreader as important

With a lack of research and accessibility concerns, we therefore do not recommend using this component without conducting research with your users and contacting the accessibility team.

Anything else

If you've used highlighted search matches in your service and seen them tested with users, please add your experiences in the comments below.

@joeedhorton joeedhorton added component help wanted Further context or research is needed to progress labels Sep 22, 2020
@isobelseacombe
Copy link

I've noticed that this isn't accessible via the menu of components in the design system - is it possible to add it to the menu?

Also, in the code snippets here https://design.homeoffice.gov.uk/components/highlighting-matches it says it is no longer in the design system. It is a component that is being tested for use in PPPT and DSA currently.

Use case in PPPT - Searching for a record with multiple search criteria. The highlight is a useful as a way of identifying which parts of the search results are matched to the search terms entered by the user

@isobelseacombe
Copy link

Can this issue be moved into a project please (I'm not sure how to do it). Where should it go - backlog or design discussion?

@karypun
Copy link
Contributor

karypun commented Apr 29, 2021

I need to document this backlog before removing it as it's tied to a few places in the current design system. Can you use the design discussion instead? There may be an issue with some of the sharing access so let me know if you run into it there.

@karypun karypun added this to Backlog in Design system backlog Jun 27, 2021
@karypun karypun moved this from Backlog to Proposed (anyone can add) in Design system backlog Jun 27, 2021
@UKHomeOffice UKHomeOffice locked and limited conversation to collaborators Apr 25, 2022
@LaurencePiercy LaurencePiercy converted this issue into discussion #369 Apr 25, 2022
@LaurencePiercy LaurencePiercy removed this from Proposed in Design system backlog Apr 25, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
component help wanted Further context or research is needed to progress
Projects
None yet
Development

No branches or pull requests

3 participants