Set controller error class in the constructor #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the error class is only set as part of the wizard constructor, which means that controllers will only have their error class set when in the context of a wizard, and not when constructed standalone. This means that testing error handling and generation cannot be done whilst exncapsualting the controller. Setting the error class on a controller at construction time rather than in the wizard post-construction allows the behaviour to be inherited in standalone controllers.
gavboulton
added a commit
that referenced
this pull request
Aug 25, 2015
Set controller error class in the constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the error class is only set as part of the wizard constructor, which means that controllers will only have their error class set when in the context of a wizard, and not when constructed standalone. This means that testing error handling and generation cannot be done whilst encapsulating the controller.
Setting the error class on a controller at construction time rather than in the wizard post-construction allows the behaviour to be inherited in standalone controllers.