Update fields for example #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefitter
requested changes
Jan 4, 2017
| - `fields`: Location of the common fields relative to the root of your project. Defaults to `__dirname + '/fields'`. | ||
| - Will not error if it can't find any views in the root of your project. | ||
|
|
||
| - Views extend like so, where route-views are the most specific: `hot-template-partials -> your-common-views -> your-route-views`. |
There was a problem hiding this comment.
Hot template partials IN YOUR AREA!
|
LGTM other than the 🔥 |
lennym
approved these changes
Jan 4, 2017
- update helper to find fields from apps/${name}/fields.js if fields not set on route
- amend readme for changes to fields
- amend example, remove fields and view false override
JoeChapman
force-pushed
the
fix-example
branch
from
3dd8227
to
9e05506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91