Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return only BigNumberish/BigNumbers from Containers, cast in Features #118

Open
nicholaspai opened this issue Aug 11, 2020 · 0 comments
Open

Return only BigNumberish/BigNumbers from Containers, cast in Features #118

nicholaspai opened this issue Aug 11, 2020 · 0 comments

Comments

@nicholaspai
Copy link
Member

Currently, container data read from on-chain is returned as a combination of string and number types, however this opens the door for precision loss. Containers should return raw data and let downstream modules cast the data as they wish.

Example:
Position container returns position stats as strings and numbers but all should just be returned as BigNumbers, including derivative stats such as GCR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicholaspai