Added support for Raritan PDU2 mib PDUs #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with Raritan PX3-1730V-V2
lunkwill42
requested changes
Mar 8, 2017
python/nav/mibs/pdu2_mib.py
Outdated
| from twisted.internet.defer import returnValue | ||
| from nav.mibs.mibretriever import MibRetriever | ||
|
|
||
| UNIT_MAP = { |
There was a problem hiding this comment.
The standardised unit names should probably be imported from the nav.models.manage.Sensor model. Units that are new to NAV should also there probably be added there, unless they sound completely esoteric.
python/nav/mibs/pdu2_mib.py
Outdated
| 'cm': 'meters', | ||
| 'meters': 'meters', | ||
| 'rpm': 'rpm', | ||
| 'degrees': 'degrees', |
There was a problem hiding this comment.
I realize the name comes from the MIB, but does it refer to angles or temperatures? :D
There was a problem hiding this comment.
There are different entries for degrees celsius and fahrenheit, so I assume it must be some sort of angle.
python/nav/mibs/pdu2_mib.py
Outdated
| ] | ||
|
|
||
|
|
||
| class PDU2(MibRetriever): |
There was a problem hiding this comment.
I would prefer all MIB retrievers to end with the Mib suffix.
lunkwill42
approved these changes
Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Raritan PX3-1730V-V2