Collect sensor readings from Lenovo/IBM PDUs (Power Distribution Units) #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmunau
suggested changes
Mar 9, 2017
python/nav/mibs/ibm_pdu_mib.py
Outdated
|
|
||
|
|
||
| class IbmPduMib(MibRetriever): | ||
| """ Custom class for retrieveing sensors from APC UPSes.""" |
python/nav/mibs/ibm_pdu_mib.py
Outdated
| self._logger.debug("Got phase power readings: %r", phases) | ||
|
|
||
| result = [] | ||
| column = self.nodes.get(PHASE_LAST_POWER_READING, None) |
There was a problem hiding this comment.
Either don't put a default here, or do not assume this is not None later in the code
There was a problem hiding this comment.
A good point. It would be really bad if the OID definition isn't present in the MIB we already compiled ourselves - this is what you get for using older code as inspiration ;)
python/nav/mibs/ibm_pdu_mib.py
Outdated
| result = [] | ||
| for index, row in outlets.items(): | ||
| for sensor in self._outlet_row_to_sensors(index, row): | ||
| result.append(sensor) |
There was a problem hiding this comment.
Maybe use result.extend() rather than an extra for loop?
python/nav/mibs/ibm_pdu_mib.py
Outdated
| description = row.get(OUTLET_DESCRIPTION) | ||
|
|
||
| voltage = dict( | ||
| oid=str(self.nodes.get(OUTLET_VOLTAGE, None).oid + str(index)), |
There was a problem hiding this comment.
None.oid will not work. If the key is missing it makes more sense to get a KeyError than an AttributeError
python/nav/mibs/ibm_pdu_mib.py
Outdated
| yield voltage | ||
|
|
||
| current = dict( | ||
| oid=str(self.nodes.get(OUTLET_CURRENT, None).oid + str(index)), |
python/nav/mibs/ibm_pdu_mib.py
Outdated
|
|
||
| power = dict( | ||
| oid=str(self.nodes.get(OUTLET_LAST_POWER_READING, | ||
| None).oid + str(index)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by SIGMA2, here is basic support for retrieving power readings from phases and outlets on the Lenovo PDUs currently being deployed.