Migrate to Python3 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okainov
reviewed
Aug 3, 2020
| @@ -9,7 +9,7 @@ | |||
| class ViewModel: | |||
| @staticmethod | |||
| def is_correct(color): | |||
| return map(operator.methodcaller("isdigit"), color) == [True] * 3 | |||
| return list(map(operator.methodcaller("isdigit"), color)) == [True] * 3 | |||
There was a problem hiding this comment.
the whole line looks suspicious, why not return all([isdigit(x) for x in color]) or something similar?
There was a problem hiding this comment.
@okainov well, this is your line, i've just fixed it a bit ;-) Feel free to submit a PR, will be able to return to it a bit later...
.travis.yml
Outdated
| python: | ||
| - "2.7" | ||
| # python: | ||
| # - "2.7" | ||
| #- "3.5" |
There was a problem hiding this comment.
Probably makes sense to update to 3.8 :)
There was a problem hiding this comment.
So far relying on whatever TravisCI suggests out of the box. Will need to revisit later with all thee versions for all dependencies...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.