Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter_OutputDirectoryNaming #49

Closed
NickCondon opened this issue Sep 8, 2021 · 5 comments
Closed

Converter_OutputDirectoryNaming #49

NickCondon opened this issue Sep 8, 2021 · 5 comments
Assignees
Labels
bug Something isn't working Medium
Milestone

Comments

@NickCondon
Copy link
Collaborator

Assuming the following Folder Structure for this example.

InputDir = \rdm...\Imaging_data\20210908
file.list(InputDir) = control1.ims, control2.ims, treatment1.ims, treatment2.ims

There is no assumption that all *.ims files are the same size/shape.

On the converter page i should be able to click add individual files > then select these 4 files and add them to the list.

OutputDirName = "Converter_Output"
OutputDir = InputDir++OutputDirName

Currently all 4 files in the list will write to this OutputDir however they currently will write into the following location: InputDir\Converter_Output"InputDir"\control1_1.tif, control1_2.tif....

Unfortunately the usecase here means that files overwrite one another and the output is simply the last file processed. All 4 .out and .json are overwritten leaving just the final files .out and .json file.

Instead the output directory order/naming should be as follows:
InputDir++OutputDirName++++StackName.tif

Where StackName = Filename+"_1, 2, 3, etc

By naming the subDirectory in the OutputDirectory the Filename, it will be unique (preventing overwritting files) and keep it organised/neat for future processing steps.

@NickCondon NickCondon added the bug Something isn't working label Sep 8, 2021
@hoangnguyen177 hoangnguyen177 self-assigned this Sep 8, 2021
@hoangnguyen177 hoangnguyen177 added this to the Beta release milestone Sep 8, 2021
@hoangnguyen177 hoangnguyen177 added this to In progress in Image Processing Portal Sep 14, 2021
@hoangnguyen177
Copy link
Contributor

Fixed at release 2.1.12. Deployed to test.

@hoangnguyen177 hoangnguyen177 moved this from In progress to Testing in Image Processing Portal Sep 17, 2021
@hoangnguyen177
Copy link
Contributor

@NickCondon @DrSpringy Please close this issue once finish testing.

@markendr
Copy link
Contributor

markendr commented Apr 4, 2024

NC to test

@NickCondon
Copy link
Collaborator Author

Some initial testing results...
Working dir = I:\IPPDATA-Q0703\Nick - Example Files\DragonflyTesting2024

No metadata.txt file = nothing works (not surprising, we should add a warning text on the converter page to alert users).

Mixed_MD is 3 different files with metadata that executed.
-Output .tif files dont have scale
-Metadata.json files are empty

Ideally output files should be within their own directory called Filename (no extension)_output within the collective output directory.

@markendr
Copy link
Contributor

markendr commented Apr 9, 2024

Thanks Nick,

We have opened CRM #240410-000752 to track (hopefully you received an email from CRM). Closing this one in github..

Regards, Mark

@markendr markendr closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Medium
Projects
Development

No branches or pull requests

4 participants