Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global-Nav Bug: Multi-Column submenu shifted #362

Closed
bignamehere opened this issue Aug 23, 2019 · 2 comments
Closed

Global-Nav Bug: Multi-Column submenu shifted #362

bignamehere opened this issue Aug 23, 2019 · 2 comments
Assignees
@whatnextjamie
Labels
BUG kind: component P3 source: internal FBCSS type: front-end
Milestone
The Fridge

Comments

@bignamehere
Copy link
Collaborator

Then a Multi-column submenu is used for the last nagivation item, the submenu is shifted to the right because of the :last-child settings seen below. Need a fix that allows for proper alignment as show for multi-column.

image

Need to determine how changing the :last-child parameters will affect other variations.
@bignamehere bignamehere added this to the 2.4.0 milestone Aug 23, 2019
@bignamehere bignamehere added this to DO in ProtoKit (Vue framework) via automation Aug 23, 2019
@francisrupert francisrupert modified the milestones: 2.4.0, The Fridge Oct 28, 2019
@francisrupert francisrupert added P3 and removed P2 labels May 20, 2020
@whatnextjamie whatnextjamie self-assigned this Aug 11, 2022
@whatnextjamie
Copy link
Contributor

BUG: multi-column submenu (last child)
last-child

Should resemble: multi-column submenu (not last child)
not-last-child

Solution: Added additional CSS to target .fsa-nav-global__list-item--multi-column:last-child
fixed

@bignamehere
Copy link
Collaborator Author

@whatnextjamie Let's review this Issue together and go over the process.

@bignamehere bignamehere reopened this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whatnextjamie whatnextjamie

Labels
BUG kind: component P3 source: internal FBCSS type: front-end
Projects
None yet
Milestone
The Fridge
Development

No branches or pull requests
3 participants
@francisrupert @bignamehere @whatnextjamie