Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Breadcrumb items as button #566

Closed
francisrupert opened this issue Feb 8, 2022 · 1 comment
Closed

BUG: Breadcrumb items as button #566

francisrupert opened this issue Feb 8, 2022 · 1 comment
Assignees
@whatnextjamie
Labels
BUG element: forms kind: component P2 source: internal FBCSS type: design

Comments

@francisrupert
Copy link
Contributor

francisrupert commented Feb 8, 2022 •
edited
Loading

Description

Breadcrumbs currently assume each item is an <a>, but may alternately be a <button>. However undesirable styles (e.g. padding, background, etc) are inherited.

Solution

Unset inherited button styles, ensuring each item works as a <a> or <button>.

Like just need to add @include reset-button(); to .fsa-breadcrumb__link (approx at _fsa.breadcrumb.scss#L64)

Screenshot of Bug

image
@whatnextjamie
Copy link
Contributor

whatnextjamie commented Aug 16, 2022 •
edited
Loading

Added "Buttons" example to fsa-style kitchen sink after adding reset-button(): to .fsa-breadcrumb__link

breadcrumb as button after

@whatnextjamie whatnextjamie mentioned this issue Aug 17, 2022
Open
@whatnextjamie whatnextjamie reopened this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whatnextjamie whatnextjamie

Labels
BUG element: forms kind: component P2 source: internal FBCSS type: design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@francisrupert @whatnextjamie