Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep values that are right censored #138

Merged
merged 5 commits into from Oct 26, 2017
Merged

Conversation

limnoliver
Copy link
Contributor

Modified parts of the Sample clean up process so that it recognizes and keeps right-censored (e.g., ">") values. Per Survival documentation, the solution I propose for this is to set the ConcLow to censoring level and ConcHigh to NA. ConcAve was calculated as 2*ConcLow for plotting purposes.

Note this does not solve plotting of right-censored values. For example, plotConcTime may plot the censored values as left-censored, whereas the line segment should be drawn upwards instead of downwards. I was having a hard time understanding how censoredSegments was implemented.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 67.688% when pulling 0a7647b on limnoliver:master into 1cfadd9 on USGS-R:master.

@ldecicco-USGS
Copy link
Collaborator

I'll take a look at the plotting shortly!

@ldecicco-USGS ldecicco-USGS merged commit 08f68d5 into DOI-USGS:master Oct 26, 2017
print(flaggedData2)
}
}
# flaggedData2 <- returnDataFrame[(returnDataFrame$ConcLow > returnDataFrame$ConcHigh),]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think we can/should keep this, just add a line to remove the NA's from the flaggedData (4 < NA = NA...and that NA should stay in)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants