Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small tweaks to improve performance #364

Merged
merged 6 commits into from
May 5, 2017
Merged

Small tweaks to improve performance #364

merged 6 commits into from
May 5, 2017

Conversation

doug-friedman
Copy link
Contributor

I made some small tweaks to improve performance.

  • any(is.na(x)) -> anyNA(x)
  • as.Date(x) -> as.Date(parse_date_time(x))

@doug-friedman
Adding gitignore
707e783
@doug-friedman
Updating checkWQPdates
8751b1f 
- Changed as.Date -> to as.Date + parse_date_time to increase speed of
date parsing
- Removed double cast to dates in L34
@doug-friedman
Replacing any+is.na with anyNA
fd3d88a 
anyNA is a faster way of checking for nulls
@doug-friedman
Speeding up date parsing for daily value files
c364d1c
@doug-friedman
Reverting back to as.Date in readNWISdv
c28e6fe 
It apparently performed 2x as well as parse_date_time in the test.
@doug-friedman
Finally reverting back to as.Date
b248735 
Sorry about that last one!
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.553% when pulling b248735 on doug-friedman:master into 66b800a on USGS-R:master.

@ldecicco-USGS ldecicco-USGS merged commit b87d448 into DOI-USGS:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doug-friedman @coveralls @ldecicco-USGS