Generalize read_field_obs, resample_to_field, and plot_var_compare #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 28, 2016 09:04
| x = as.numeric(as.POSIXct(data$DateTime)) | ||
| y = data$Depth | ||
| z = data$Observed_wTemp | ||
| z = data[,paste0('Observed_', var_name)] |
There was a problem hiding this comment.
didn't know that data[, paste0('Observed','_temp')] is the same as data[[paste0('Observed_', var_name)]].
|
Looks good to me. It would be nice to add a test to verify this working across variables though. |
|
Those files have all lines changed because they were in the old weirdo mac format with only \CR as a newline character (which is why the old files show up in github as being all one line). I've switched them all to *nix format. |
|
Failures are github 403's. Tests added. Merging. |
lawinslow
pushed a commit
that referenced
this pull request
Jan 28, 2016
Generalize read_field_obs, resample_to_field, and plot_var_compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is to use this comparison functionality on any parameter. These changes currently break backward compatibility with field data using "wtemp" header. This also changes output of
get_varto no longer bewtr_andelev_, now istemp_for temp (generalized tovarname_based on parameter passed) andvarname.elev_for any bottom referenced data.We may want to maintain more backwards compatibility, but that does make the other functionality harder to implement as it is easy to assume the header is
varnameandvarname_depthas opposed to sometimes temp being namedwtrorwtemp.