Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a surprising turn of events, it turns out that American Samoa, Guam, and the Northern Marianas do have a HUC code - it's "22". Our own documentation on this surprise is not consistent:
To dig into these inconsistencies a bit I have a snippet of code:
There are two sites that are missed when we query by
HUC
rather thanstateCd
, they have the following characteristics:I would assume that we would probably miss some NWIS sites the CONUS + AK + HI + Caribbean regions if we did the same
HUC
vsstateCd
comparison. I did not test this theory because creating the inventory for CONUS + AK + HI + Caribbean was running slowly for me (> 30 min). Because of this assumption, I have decided to keep the query method consistent for all regions.I am tagging @limnoliver for this review because this is more of a overall "methods" PR rather than an in depth pipeline review.
Closes #19