add pkg_version & fix build/check errors #11
Conversation
Merge branch 'master' of https://github.com/USGS-R/streamMetabolizer Conflicts: R/metab_simple.R
|
👍 |
add pkg_version & fix build/check errors
| @@ -24,7 +24,9 @@ | |||
| #' | |||
| #' @author Alison Appling, Jordan Read; modeled on lakeMetabolizer | |||
| #' @examples | |||
| #' metab_simple(data=data.frame(date.time=rep(as.Date("2015-04-15"), 24), DO.obs=1:24, DO.sat=rep(14, 24), PAR=sin((1:24)*pi/24)^8, temp.water=15)) | |||
| #' metab_simple(data=data.frame( | |||
There was a problem hiding this comment.
Was thinking about this basic structure. Should we skip the input for DO.sat and calculate that internally? Seems a bit redundant w/ DO.obs, given we recommend it gets passed through o2.at.sat anyhow to build DO.sat. Also, could support additional args to o2.at.sat with the .... Just a thought. I see some pros and cons either way.
There was a problem hiding this comment.
do.sat was passed in for LakeMetabolizer because the data and metadata requirements to calculate it include information you might not normally pass in. Model choice, elevation or barometric pressure. Making people calculate it ahead of time adds tasks for the user but reduces data inputs.
There was a problem hiding this comment.
Ok, but a lot of use cases assume salinity~0, and use altitude for baro, so since wtr.temp and do.obs are already there, it doesn't seem onerous to support
metab_simple(data = data.frame(date.time=rep(as.Date("2015-04-15"), 24), DO.obs=1:24, temp.water=15), altitude=424)
# as input to
metab_simple(data, ...)There was a problem hiding this comment.
How about a separate function that does all the data preparation for you?
Then we can also (later) create a high-level function that both prepares
and models the data, but our core modeling functions will remain relatively
short and focused on a single activity (fitting a model).
On Thu, Apr 23, 2015 at 7:54 AM, Jordan S Read notifications@github.com
wrote:
In R/metab_simple.R
#11 (comment)
:@@ -24,7 +24,9 @@
#'
#' @author Alison Appling, Jordan Read; modeled on lakeMetabolizer
#' @examples
-#' metab_simple(data=data.frame(date.time=rep(as.Date("2015-04-15"), 24), DO.obs=1:24, DO.sat=rep(14, 24), PAR=sin((1:24)*pi/24)^8, temp.water=15))
+#' metab_simple(data=data.frame(Ok, but a lot of use cases assume salinity~0, and use altitude for baro,
so since wtr.temp and do.obs are already there, it doesn't seem onerous to
supportmetab_simple(data = data.frame(date.time=rep(as.Date("2015-04-15"), 24), DO.obs=1:24, temp.water=15), altitude=424)# as input to
metab_simple(data, ...)—
Reply to this email directly or view it on GitHub
https://github.com/USGS-R/streamMetabolizer/pull/11/files#r28959102.
Alison Appling
Postdoctoral Fellow, USGS Powell Center
USGS Center for Integrated Data Analytics and University of Wisconsin -
Madison
Phone: (608) 821-3927
There was a problem hiding this comment.
Either way, was just laying out the thought process for both.
There was a problem hiding this comment.
@lawinslow we are going to do the low level stuff and do conversions elsewhere. Ignore my early morning musings :)
No description provided.