Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Booking] Add Location Label #322

Open
tsznokwong opened this issue Nov 23, 2018 · 6 comments
Open

[Booking] Add Location Label #322

tsznokwong opened this issue Nov 23, 2018 · 6 comments
Labels
alignment Alignment to other platform good first issue Issue for beginners iOS Platform: iOS

Comments

@tsznokwong
Copy link
Contributor

Expected behavior

Align with Android
Showing location information of facilities
e.g. Badminton Court 2 duplicated
1 is in Sports Hall
1 is in new Sports Centre

Actual behavior

Steps to reproduce

Environment

  • App Version:
  • Phone Model:
  • OS Version:
  • OS Language:
@tsznokwong tsznokwong added enhancement Improvement help wanted Require extra help from others iOS Platform: iOS labels Nov 23, 2018
@elise-ng elise-ng added the good first issue Issue for beginners label Dec 22, 2018
@tsznokwong tsznokwong added alignment Alignment to other platform and removed enhancement Improvement help wanted Require extra help from others labels Jan 7, 2019
@elise-ng
Copy link
Contributor

needa update implementation of info card and show location there as well...

@elise-ng
Copy link
Contributor

img_1db43cf75cd1-1
after the server fix for #333 it will show location in facility name...

@frankwangyufei
Copy link

Actually now we includes location in name, still need this meh?

@elise-ng
Copy link
Contributor

elise-ng commented Feb 26, 2019

depends on how do we want to align the ui b/t iOS and android... cuz for iOS we didn't implement location label in time slot ui and info card...

we can remove the server-appended location (after next release finishes adoption) if we decide to go with the location label route? @tsznokwong your opinion?

currently the pr for #333 doesn't append the location in name for /reservations response, asking @klwuco if we can implement that as well...

@tsznokwong
Copy link
Contributor Author

can use location label tho some location label is meaningless

@klwuco
Copy link

klwuco commented Feb 26, 2019

Now the location is appended after the name for /reservations as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alignment Alignment to other platform good first issue Issue for beginners iOS Platform: iOS
Projects
None yet
Development

No branches or pull requests

4 participants