Issue 1271 colormap on object #1523
Conversation
gm is stored at init time (should we do the same for template?) pipeline now have a getcolormap() func that look for the colormap to use in this order: * graphic method has the colormap attribute * canvas has the colormap attribute set * otherwise use vcs.colormap fix #1271
forgot one class where init needed to be updated
vector pipeline was still expecting gm as argument to plot function
|
I am going this branch. |
|
@aashish24 review? |
| @@ -865,7 +865,7 @@ def __init__(self, gui=0, mode=1, pause_time=0, | |||
| self._canvas_id = vcs.next_canvas_id | |||
| self.ParameterChanged = SIGNAL('ParameterChanged') | |||
| vcs.next_canvas_id += 1 | |||
| self.colormap = "default" | |||
| self.colormap = None | |||
There was a problem hiding this comment.
Why not leave it to "default"?
There was a problem hiding this comment.
Because there are three spots where cmap can be set, so I need to know if user did set it or not.
|
I think I sent a request to rerun tests on this let's wait. |
|
|
||
| # For now, we'll just throw everything at plot. This might need to be | ||
| # broken up into set_data, set_template, etc methods... | ||
| def plot(self, data1, data2, template, graphics_method, grid, transform): | ||
| raise NotImplementedError("Missing override.") | ||
|
|
||
| def getcolormap(self): |
There was a problem hiding this comment.
shouldn't it be called getColorMap(self) so as to be consistent with rest of the naming convention?
There was a problem hiding this comment.
That's reasonable will do. Will look at your if/else comments as well.
|
@doutriaux1 mostly looks good to me. Just has some minor suggestion. I hope you won't mind addressing these if you think they are reasonable. |
|
merge from master failed. DO NOT MERGE YET please. Fixing it. |
|
@doutriaux1 sounds good to me. If buildbot is happy, lets go ahead and merge it. |
fixed typo in comment, mainly trying to retrigger builds
Issue 1271 colormap on object
goes with: CDAT/uvcdat-testdata#62
@sankhesh @aashish24 please review