Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sejal/frontend311 delete reviews #317

Merged
merged 16 commits into from
Jul 7, 2024

Conversation

sejal-agarwal
Copy link
Contributor

@sejal-agarwal sejal-agarwal commented Jul 5, 2024

Description

Ensured that users can post reviews. Additionally, users can delete their own reviews.

Screenshot 2024-07-05 at 7 27 04 AM

Closes #311

How to Test

Checklist

  • The code includes tests if relevant
  • I have actually self-reviewed my changes and done QA

@sejal-agarwal sejal-agarwal marked this pull request as ready for review July 5, 2024 15:10
@sejal-agarwal sejal-agarwal requested review from a team as code owners July 5, 2024 15:10
Copy link
Contributor

@CaelumD25 CaelumD25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really have much to say other than nice work, and sorry it took so long to look at!

As far as I'm concerned it seems to work well, and when I'm testing it manually you can only delete your own reviews.

The only thing that we want to change is the wrapping of stars on smaller devices, but really it doesn't bother me much, and I doubt anyone's still using a device that small.
image

@sejal-agarwal
Copy link
Contributor Author

Don't really have much to say other than nice work, and sorry it took so long to look at!

As far as I'm concerned it seems to work well, and when I'm testing it manually you can only delete your own reviews.

The only thing that we want to change is the wrapping of stars on smaller devices, but really it doesn't bother me much, and I doubt anyone's still using a device that small. image

I've tried the smallest screen sizes and I'm not seeing the stars wrapping so I'm gonna leave it

@sejal-agarwal sejal-agarwal merged commit 882199d into master Jul 7, 2024
49 checks passed
@sejal-agarwal sejal-agarwal deleted the sejal/frontend311-delete-reviews branch July 7, 2024 02:20
@sejal-agarwal sejal-agarwal self-assigned this Jul 7, 2024
@sejal-agarwal sejal-agarwal mentioned this pull request Jul 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Reviews
3 participants