Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer timesteps giving error in disaggregation #110

Closed
shahryaramd opened this issue Nov 22, 2017 · 5 comments
Closed

Longer timesteps giving error in disaggregation #110

shahryaramd opened this issue Nov 22, 2017 · 5 comments
Assignees
Milestone

Comments

@shahryaramd
Copy link

The timesteps larger than 360min are showing an error while running MetSim. This is the error showing up:

image

@tbohn
Copy link
Collaborator

tbohn commented Nov 22, 2017

I'm not sure, but I think the timestep length should divide into 24 hours evenly. 360 min = 10 hours, not an integer divisor of 24hours.

@shahryaramd
Copy link
Author

Actually the same error shows up for other longer timesteps of 480, 720 min also

@arbennett
Copy link
Member

I am fairly sure this is an issue with the algorithm implemented to calculate the time of min and max daily temperatures. If the timestep is too long it may end up being that the transition from day to night is not captured so the algorithm fails.

@jhamman
Copy link
Member

jhamman commented Nov 27, 2017

I think we just need to raise an informative error if the disaggregation timestep is not within a reasonable bound. Maybe:

  • divisible into 24 hours
  • <= 6 hours

@tbohn: 360 min == 6 hours 😉

@arbennett arbennett added this to the 2.0.0 milestone Jan 25, 2018
@jhamman jhamman mentioned this issue Feb 16, 2018
4 tasks
@arbennett
Copy link
Member

Solved in #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants