-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment CI #89
Comments
More info: automated process should be
Presumably CI kicks in at that point and runs tests (again) and builds the docker container. I guess we could also build locally and upload. An example of this type of release process can be found in the Sparrow repository although this one should be in Javascript, not Python. |
@CannonLock it would be great to get an automated deployment process rolling at some point. Do you think this is feasible? |
@davenquinn That all looks good minus:
If this is running as a github CI I don't see how this is possible. |
@CannonLock I agree that if everything is handled within GitHub CI, these checks take care of themselves, as the deployment will fail if submodule commits don't exist. I was envisioning this as part of the "end-to-end" workflow, where there is an internal "deploy" script that tests locally, and runs some pre-checks before tagging/uploading the. version. This can ensure that all submodules are available, etc. before sending it to CI. Fundamentally, either way should work |
#102 Adds the a tagging system that with the correct kubernetes objects ( documented ) can be used to set this up. It additionally tests the build which will test that the above items are valid. I think the one thing left to build from this list are:
|
We need a deployment CI! A functional production deployment CI for this project will check that
main
branchmain
branch and pushed.It would also be nice to check that a few pages render properly, as a basic test
The text was updated successfully, but these errors were encountered: