Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Document adoption of Conventional Commits. #685

Merged
merged 3 commits into from
Sep 5, 2017

Conversation

apetro
Copy link
Contributor

@apetro apetro commented Sep 5, 2017

Document in contributing guidance to use Conventional Commits, while emphasizing that contributing guidance is not intended to be an insurmountable barrier to contribution.


Contributor License Agreement adherence:

+ `github`
+ `md`
+ `npm`
+ `package`
Copy link
Contributor

@ChristianMurphy ChristianMurphy Sep 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ what is the difference between dependency, dependency upgrade, and package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno. Colorable argument for collapsing these. I figured the first step towards that was writing down what we've got so far.

We have not yet formalized scopes. In practice scopes used so far include:

+ `changelog`
+ `ci`
Copy link
Contributor

@ChristianMurphy ChristianMurphy Sep 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci is already a type, do we also want it to be a scope?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. :)

@apetro apetro merged commit 7d4e3a1 into uPortal-Attic:master Sep 5, 2017
@apetro apetro deleted the doc-conventional-commits-clean branch September 5, 2017 21:57
@davidmsibley davidmsibley added this to the 6.6.1 milestone Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants