Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

build(maven): configure maven release plugin commit prefix #686

Merged
merged 1 commit into from
Sep 8, 2017
Merged

build(maven): configure maven release plugin commit prefix #686

merged 1 commit into from
Sep 8, 2017

Conversation

ChristianMurphy
Copy link
Contributor

this avoids a conflict between the conventional commit message linter and the maven release plugin.

resolves #682


Contributor License Agreement adherence:

this avoids a conflict between the conventional commit message linter
and the maven release plugin.

resolves #682
@davidmsibley
Copy link
Contributor

can we have it as chore(release): [maven-release-plugin] or will that still break the commit hook?

@ChristianMurphy
Copy link
Contributor Author

It would still break, this time with the title length.

chore(release): [maven-release-plugin] prepare release angularjs-portal-parent-6.6.0

is 84 characters log, header max length is expected to be <72 characters.
ref: https://github.com/marionebl/commitlint/blob/e6ef0721a230b90fc17955b33983c8bea2767d7f/%40commitlint/config-angular/index.js#L7

@ChristianMurphy
Copy link
Contributor Author

ChristianMurphy commented Sep 7, 2017

@davidmsibley
I'm taking an educated guess that you want to preserve information that release commits were autogenerated.
Would setting scm username for the release commits to Maven Release Plugin communicate that effectively?

📓 That would remove the record of who cut the release.

@davidmsibley
Copy link
Contributor

I'm trying to figure out if my hesitation here is rational. I know that we do have more than a couple of internal Jenkins jobs that parse commit messages and look for that standard maven release formatted commit message. But those jobs don't run on these repos, so I kind of think it'll be fine. Anytime you're changing from a standard format to custom, it warrants a little thought because it could hurt you down the line. I'm reminded of a recent discovery by a coworker that he couldn't easily import years of server logs into a log summarizer/visualizer because on day one they'd decided to tweak the apache log format a bit to add more information (thus breaking the OOTB log parser).

There may be some irrational fear here as well. At the moment I place little to no value in commit message linting, and I despise commit hooks. So the idea that we change our build system to accommodate them is unpleasant. Maybe someday in the near future the value of commit message linting will become clear and I'll love it the same way I changed my opinion on Greenhopper the moment it started opening pull requests.

tl;dr: I've become a curmudgeon, and maybe when @vertein and @apetro get back in to the office tomorrow you'll get a better review 😄

@apetro
Copy link
Contributor

apetro commented Sep 8, 2017

How much longer are we going to keep using Maven to release a product that's got nothing to do with Java? The sooner we turn the corner, the sooner this is moot and we get to re-solve these problems with other releasing tools. 😄

Copy link
Contributor

@vertein vertein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it. I understand some reservation. I think we do this until we stop using the maven plugin anyways.

@ChristianMurphy ChristianMurphy merged commit 1d3dcf1 into uPortal-Attic:master Sep 8, 2017
@ChristianMurphy ChristianMurphy deleted the build/update-maven-release-plugin-prefix branch September 8, 2017 16:42
@davidmsibley davidmsibley added this to the 6.6.1 milestone Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven release plugin conflicts with commit message hook
4 participants