-
Notifications
You must be signed in to change notification settings - Fork 27
build(maven): configure maven release plugin commit prefix #686
build(maven): configure maven release plugin commit prefix #686
Conversation
this avoids a conflict between the conventional commit message linter and the maven release plugin. resolves #682
can we have it as |
It would still break, this time with the title length.
is 84 characters log, header max length is expected to be <72 characters. |
@davidmsibley 📓 That would remove the record of who cut the release. |
I'm trying to figure out if my hesitation here is rational. I know that we do have more than a couple of internal Jenkins jobs that parse commit messages and look for that standard maven release formatted commit message. But those jobs don't run on these repos, so I kind of think it'll be fine. Anytime you're changing from a standard format to custom, it warrants a little thought because it could hurt you down the line. I'm reminded of a recent discovery by a coworker that he couldn't easily import years of server logs into a log summarizer/visualizer because on day one they'd decided to tweak the apache log format a bit to add more information (thus breaking the OOTB log parser). There may be some irrational fear here as well. At the moment I place little to no value in commit message linting, and I despise commit hooks. So the idea that we change our build system to accommodate them is unpleasant. Maybe someday in the near future the value of commit message linting will become clear and I'll love it the same way I changed my opinion on Greenhopper the moment it started opening pull requests. tl;dr: I've become a curmudgeon, and maybe when @vertein and @apetro get back in to the office tomorrow you'll get a better review 😄 |
How much longer are we going to keep using Maven to release a product that's got nothing to do with Java? The sooner we turn the corner, the sooner this is moot and we get to re-solve these problems with other releasing tools. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it. I understand some reservation. I think we do this until we stop using the maven plugin anyways.
this avoids a conflict between the conventional commit message linter and the maven release plugin.
resolves #682
Contributor License Agreement adherence: