Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

fix(license): remove scss auto-license in /docs #693

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

vertein
Copy link
Contributor

@vertein vertein commented Sep 15, 2017

Our github pages were looking funky:

image

vs, what it should look like
image

SCSS files used in jekyll have to start with a front matter comment and can't start with a header license. This excludes scss files in the docs directory from having the license header added automatically and fixes the existing comment to move beneath the front matter comment.

Similar to uPortal-Attic/uportal-app-framework#527

{Substantive content goes here. Summarize the changeset and why the changeset.}


Contributor License Agreement adherence:

SCSS files used in jekyll have to start with a front matter comment.
Copy link
Contributor

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM 👍
Thanks @vertein! 🙇‍♂️

@vertein
Copy link
Contributor Author

vertein commented Sep 15, 2017

The CI failure is being caused by linting errors in this changeset: #692

@davidmsibley davidmsibley merged commit 2f0f9ff into uPortal-Attic:master Sep 20, 2017
@davidmsibley davidmsibley added this to the 6.6.1 milestone Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants