This repository has been archived by the owner on May 4, 2022. It is now read-only.
Remove "categories" from app dir UI #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "Categories" tab selector from /web/apps . Does not entirely remove categories feature. If users otherwise navigate to a category filtered view, that works. Just removes tab UI control for triggering this view.
Stop showing chips for categories in app directory entries, both as listed en masse and as rendered on details page.
ChristianMurphy
approved these changes
Sep 15, 2017
|
Agree on the screenshot. Localhost mock is apparently broken ( #696 ). So I suppose I'll have to get a "real" development environment going to take screenshots... |
|
👍 |
Doug-Reed
approved these changes
Sep 19, 2017
davidmsibley
approved these changes
Sep 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Categories are confusing. Stop bothering users with them.
Removes navigation tab within app directory.
Removes categories chips from app directory entries as rendered en masse.
Removes categories section from app directory details page.
Categories are unfit for purpose because they are tied up with permissions. Gotta have permission on the category to see the category qua category, but permission on the category inherits as permission on the portlets within the category. In practice this is confusing, yields to misconfigurations, accidental permission grants, a mess.
Maybe someday no-permission-complications "tags" could be re-introduced as a feature. Maybe we'll never need it.
But for near term it has become clear that we want to only grant permissions at the individual
portlet-definitionlevel and stop trying to get permissions on categories right.This changeset just removes categories superficially from the UI. However, this will unblock removing categories whenever we can on the back-end with no weird UI consequences at that time.
Contributor License Agreement adherence: