This repository has been archived by the owner on May 4, 2022. It is now read-only.
Renaming angularjs-portal to uportal-home #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
Sep 27, 2017
| @@ -52,12 +53,12 @@ See [documentation site][GitHub Pages site]. | |||
| ### Modules | |||
|
|
|||
| #### Frame | |||
| Frame was so cool it moved to [its own project](https://github.com/UW-Madison-DoIT/uw-frame). | |||
| uPortal Home is a [uPortal App-Framework project](https://github.com/uPortal-Project/uportal-app-framework). | |||
There was a problem hiding this comment.
Good to know. 👍
I was under the mistaken impression that the reverse was true.
package.json
Outdated
| "name": "web", | ||
| "version": "5.0.0", | ||
| "description": "angular my-uw", | ||
| "name": "@uportal/uportal-home", |
There was a problem hiding this comment.
❓ per #700 could/should this be @uportal/home?
There was a problem hiding this comment.
whoops! oh yeah!
apetro
approved these changes
Sep 27, 2017
ChristianMurphy
approved these changes
Sep 27, 2017
Closed
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing groupId, artifactId, npm package name, and restructuring interior folders.
Look through the individual commit diffs for a play-by-play, the huge folder moves are confined to one commit.
addresses #697
Contributor License Agreement adherence: