This repository has been archived by the owner on May 4, 2022. It is now read-only.
Apply license headers to source files #522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable adding apereo license header to all files programatically
vertein
force-pushed
the
MUMUP-2885-Apply-License-marking
branch
from
8392c09
to
5604b4f
Compare
ChristianMurphy
approved these changes
Sep 13, 2017
There was a problem hiding this comment.
LGTM, thanks @vertein! 👍
❓ Did the Maven plugin add all the license headers in this PR? Or did some have to be manually added?
❓ How often will the project be checking license header compliance? (Per Release, Per Commit, Other)
👷 AppVeyor appears to have had a flaky run, you may want to restart it
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-readable POM C:\projects\uw-frame\pom.xml: input contained no data @ C:\projects\uw-frame\pom.xml
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project edu.wisc.my.apps:uw-frame:5.1.1-SNAPSHOT (C:\projects\uw-frame\uw-frame-java\pom.xml) has 1 error
[ERROR] Non-readable POM C:\projects\uw-frame\pom.xml: input contained no data @ C:\projects\uw-frame\pom.xml
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
Command exited with code 1
|
Maven plugin did all the license adding. |
vertein
force-pushed
the
MUMUP-2885-Apply-License-marking
branch
from
5604b4f
to
fef4c92
Compare
Add the Apereo license header to source files
Checks to see if license header has been added to source files
vertein
force-pushed
the
MUMUP-2885-Apply-License-marking
branch
from
fef4c92
to
ae8acaf
Compare
Ignore the test output directories when checking for license on source files
vertein
force-pushed
the
MUMUP-2885-Apply-License-marking
branch
from
01f2fda
to
87aa20a
Compare
Momentarily turn off cache
Turn cache back on now that build passed
1 task
|
Closing in favor of #523 because I couldn't get the AppVeyor build to succeed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked at UW-Madison with MUMUP-2885.
First commit adds the maven license plugin and configures usage, including using Apereo's license header.
Second commit adds the license header to the files.
Third commit add CI check to ensure that license headers have been added.
Contributor License Agreement adherence: