Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add whitespace linting for all files #106

Closed
mduan opened this issue Mar 3, 2014 · 5 comments · Fixed by #157 or #158
Closed

Add whitespace linting for all files #106

mduan opened this issue Mar 3, 2014 · 5 comments · Fixed by #157 or #158
Assignees

Comments

@mduan
Copy link
Contributor

mduan commented Mar 3, 2014

Currently, we only have whitespace linting for python files. However, we should enforce whitespace rules for all source files.

Some things to lint for include:

  • disallowing tabs
  • disallowing trailing whitespace
  • enforcing 80-char line length
@divad12
Copy link
Member

divad12 commented Mar 3, 2014

Enforcing 80-char line length might be tricky since there are some URLs and lines of code that just don't fit in 80 chars.... The rest sounds good.

@jlfwong
Copy link
Member

jlfwong commented Mar 3, 2014

Sensible linters don't complain about lines that are > 80 characters when there's a word longer than 80 characters on that line (our python linters deal with this gracefully)

@divad12
Copy link
Member

divad12 commented Mar 3, 2014

@phleet Sweet 👍

@mduan
Copy link
Contributor Author

mduan commented Apr 18, 2014

Looks like JSHint currently doesn't support detecting trailing whitespace on empty lines, and they're removing the ability to check for trailing whitespace in a future release: jshint/jshint#1554. So we'll need to use something else for checking for trailing whitespace in JS files.

@divad12
Copy link
Member

divad12 commented Apr 19, 2014

Looks like that issue references https://github.com/mdevils/node-jscs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants