Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freedom-pgp-e2e build updates: newest uproxy-lib, grunt-typescript->grunt-ts #455

Closed
agallant opened this issue Oct 9, 2014 · 1 comment
Assignees

Comments

@agallant
Copy link
Collaborator

agallant commented Oct 9, 2014

This should also result in a newer version of Typescript being used for builds, allowing for merging external module names. microsoft/TypeScript#52

@agallant agallant self-assigned this Oct 9, 2014
@agallant
Copy link
Collaborator Author

Pushed a few commits that should address this. See:
freedomjs/freedom-pgp-e2e@392188b
freedomjs/freedom-pgp-e2e@89c6f96
freedomjs/freedom-pgp-e2e@dcdf599

Went fairly smoothly, with one note/TODO - Rule.typescriptSrc in uproxy-lib/tools/common-grunt-rules does not work for karma for running tests. Basically all you need to do for karma is also build the spec file at the same time, so for now I'm doing that manually as there is no appropriate build rule I saw (the jasmine rule and the specDecl rules do not work).

Since we want to move uproxy towards karma anyway at some point soon we should either add this rule or possibly even change the existing rules. For expediency though I just pushed it as is for now.

@iislucas iislucas modified the milestone: v0.9 Allardice (Web Store Feature Complete) Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants