New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory gets overfilled after teleporting and setting the second mark #114
Comments
Bug because you shouldn't be able to OOM the server so easily, even if you have to be a moderator to do it. |
I feel the voxelmanip volume, and therefore memory use, should be limited in worldedit not in the voxelmanip. A limit setting that can be set according to server memory available. |
Related: #97 |
ps can be used to give information about memory:
Which one would l need to choose? |
Why closed? |
l tried to measure the memory difference but l didn't have success, the value was to small, e.g. 278545 nodes, -4 KiB. |
duplicate of #97 |
l tried this more times:
At first execute
/teleport 2000 0 0
then
//pos1
after that
/teleport 3000 1000 1000
and then
//pos2
After executing the last chatcommand, minetest gets stuck in some infinite loop or something similar
and if l wait and do not quickly quit minetest, my memory gets filled more and more (no OOM crash happens) and then l need to reboot my pc because of memory problems
Now l got a bad alloc crash:
l took a look at worldedit_commands/mark.lua:
manip:read_from_map is executed for the entire area, the area is big (a billion nodes)
so minetest tries that and fills up all memory,
the bad alloc maybe happened because it tried to reserve/allocate more memory than l have
obviously wordledit can be used to crash the server pc by simply setting pos1 and pos2 far away from each other
l guess l need to forgo my attempt on setting one billion nodes at once using worldedit.
At least l know that ~2.5 million nodes take ~0.3 seconds (with my changes).
The text was updated successfully, but these errors were encountered: