Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non unique object names #16

Open
bb-Ricardo opened this issue Oct 19, 2020 · 3 comments
Open

Allow non unique object names #16

bb-Ricardo opened this issue Oct 19, 2020 · 3 comments

Comments

@bb-Ricardo
Copy link

NetBox allows to assign the same name for different objects as long as there is a secondary unique key.

Descussion on this issue: netbox-community/netbox#2669

@joni1993
Copy link
Contributor

I think this may be out of scope, because Icinga requires unique host names. The Import source also required a unique attribute for identification.

We could work-around this with a Boolean config option, which appends _1,_2,... on any duplicate host name, if that's applicable.

@bb-Ricardo
Copy link
Author

I faced the same issue in another project and solved it by appending the site in brackets if site was set and object name not unique.

Would this be a possible solution?

@mrgohin
Copy link
Contributor

mrgohin commented Feb 20, 2021

As @joni1993 already mentioned for Icinga is an unique object_name mandatory.

So the problem which are you facing needs to be solved by creating a joined object_name consisting of multiple field values. Of course under the hood it isn't pretty but you can override ui with display_name attribute.

Since Director offers this solution by modifiers for an import source. I don't see any reason to implement this to the module. The modules purpose is to deliver data from a foreign source as modifiable as possible to Director.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants