New SPM product: UBQRScanner #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// the successful scanning of a code or specific errors are received via the `QRScannerViewDelegate` methods. | ||
| /// - Important: Apps using this view must provide a value for `NSCameraUsageDescription` in their `Info.plist`, | ||
| /// else the app will crash as soon as the `startScanning()` method is called. | ||
| public class QRScannerView: UIView { |
There was a problem hiding this comment.
I don't think it should be necessary to subclass this. There is no UI except for the camera view, and if we want to change something in this class, I think it's better to think about changing it in the module itself than creating a subclass.
| } | ||
| NotificationCenter.default.addObserver(forName: UIApplication.didBecomeActiveNotification, object: nil, queue: nil) { [weak self] _ in | ||
| guard let self = self else { return } | ||
| if let lastIsRunning = self.lastIsRunning, lastIsRunning == true { |
There was a problem hiding this comment.
This is a good candidate for a guard structure
ubfelix
force-pushed
the
feature/qr-scanner-view
branch
from
eaec527
to
bb9476e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new product
UBQRScannerto the UBKit library. The core of this product is a classQRScannerView, aUIViewsubclass that provides functionality related to the scanning of QR codes and other supported formats. Internally, it uses anAVCaptureSession.Successfully scanned codes (as Strings) and errors are received via the
QRScannerViewDelegatemethods.