delete nullability for data-parsers #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerki
force-pushed
the
feature/structured-concurrency
branch
from
6e527e0
to
46214cb
Compare
|
SOTA-Diskussion: Approved |
zenokoller
force-pushed
the
feature/structured-concurrency
branch
from
df7079c
to
11b0bde
Compare
|
outdated changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a quite a few networking special cases because we distinguish between null-Data and empty-Data for successful requests. Even though both cases might exist, I argue that the have pretty much the same semantics. Therefore I suggest we just replace a (success) null-Data response with an empty-Data instance.