Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes user defaults bool decoding #39

Merged
merged 2 commits into from Oct 14, 2022
Merged

fixes user defaults bool decoding #39

merged 2 commits into from Oct 14, 2022

Conversation

stmitt
Copy link
Collaborator

@stmitt stmitt commented Oct 14, 2022

If a UserDefault value is passed via launchArgument for XCUITest it is always passed as a string therefore we try to interpret the string as a fallback. https://github.com/admin-ch/CovidCertificate-App-iOS/blob/main/CovidCertificate/SharedUI/Helpers/UBUserDefault/UBUserDefault.swift#L63-L89

If a UserDefault value is passed via launchArgument for XCUITest it is always passed as a string therefore we try to interpret the string as a fallback
@stmitt stmitt requested a review from a team October 14, 2022 14:14
@maerki maerki merged commit ce771cf into main Oct 14, 2022
@maerki maerki deleted the feature/userdefaults-bool branch October 14, 2022 14:17
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Oct 14, 2022

Unit Test Results

    1 files  ±0      3 suites  ±0   1m 56s ⏱️ ±0s
165 tests ±0  165 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ce771cf. ± Comparison against base commit ce771cf.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants