Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light/dark themes #287

Open
fossfreedom opened this issue Mar 25, 2022 · 6 comments
Open

Add light/dark themes #287

fossfreedom opened this issue Mar 25, 2022 · 6 comments

Comments

@fossfreedom
Copy link
Member

For each theme we should have a tickbox next to the apply button to allow the end-user to choose a dark/light variant of the theme.

So if checking light - the preview picture should show the light variant. Likewise, when clicking apply the light desktop config should apply.

@Lovegupta112
Copy link

Yes.I can but could you explain where you have to add tickbox

@fossfreedom
Copy link
Member Author

Probably something like this (obviously spacing needs sorting)

image

<div class="custom-control custom-switch">
                          <input type="checkbox" class="custom-control-input" id="customSwitch1" >
                          <label class="custom-control-label" for="customSwitch1">Light</label>
                        </div>

in data/default.html line 50

@Lovegupta112
Copy link

Lovegupta112 commented Apr 3, 2022

Ok I will give my best , plz assign to me

@Lovegupta112
Copy link

Lovegupta112 commented Apr 4, 2022

When I clone this repo in my pc , some html pages are not showing results in the browser ,
What should I do , bcz I can't add dark/light theme without seeing results

But if you give permission so I can add code for dark/ light themes at line 50 in data/default.html without seeing results.
intro

@fossfreedom
Copy link
Member Author

Please do read the readme. You have to install and compile certain stuff.

@Lovegupta112
Copy link

Ok , i didn't know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants