Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Support #1

Open
PN1019 opened this issue Jul 18, 2017 · 0 comments
Open

Offline Support #1

PN1019 opened this issue Jul 18, 2017 · 0 comments

Comments

@PN1019
Copy link
Collaborator

PN1019 commented Jul 18, 2017

As per the suggestion by udacity reviewer,says that:

You should use an empty view. An empty view is a view that appears in a gridview, listview, recyclerview, or equivalent when no data is present to display. For example, if the internet is disabled

Because you are using a recyclerview, you have to implement this yourself, as gridview, and listview already have this functionality built in. You can learn how to do this a couple of different ways here: http://stackoverflow.com/questions/28217436/how-to-show-an-empty-view-with-a-recyclerview
My personal suggestion is to extend recyclerview.

This helps user experience by showing why the application is behaving a certain way. In this case, it will alert the user the app won't work correctly without internet.

@PN1019 PN1019 added this to the Open milestone Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant