Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raspberry 4 Support #29

Closed
iperniaf opened this issue Mar 24, 2021 · 12 comments
Closed

Raspberry 4 Support #29

iperniaf opened this issue Mar 24, 2021 · 12 comments

Comments

@iperniaf
Copy link
Contributor

Hi,
I'm using your lib with a rpbi 4 and it needs some fixes.
¿Can I contribute to the community fixing them?

@UedaTakeyuki
Copy link
Owner

Would you please tell me which problem and fixing?
I've not heard of any problem with RRi4.

@iperniaf
Copy link
Contributor Author

On mh_z19.py script, line 39, you select serial port using strict Rpi model.
Rpi4 model is not listed, so it tries to use ttyAMA0 port, and the correct one is ttyS0

@UedaTakeyuki
Copy link
Owner

Weird, line 29 can't be passed because Raspberry Pi OS must have /dev/serial0 as a symbolic link.
Do you use other OS?

@iperniaf
Copy link
Contributor Author

yes, i'm using a raspberry image on a docker container running on balena etcher OS

@UedaTakeyuki
Copy link
Owner

I see!

So, the necessary fix might be as following 2.

  1. Add RPi4 definition to https://github.com/UedaTakeyuki/getrpimodel
  2. Add "4 Model B" to line 31

right?

@UedaTakeyuki
Copy link
Owner

Add RPi4 definition to https://github.com/UedaTakeyuki/getrpimodel

Sorry, this was my missunderstanding, now RPi4 is in getrpimodel.
So, nesessary fix might be only #2.

I welcome your pull request!

@iperniaf
Copy link
Contributor Author

I have no permision to push my changes on a new branch

@UedaTakeyuki
Copy link
Owner

Not push directory, instead, you can make pull request.

@iperniaf
Copy link
Contributor Author

iperniaf commented Mar 24, 2021

done!
I have an extrage behavior.
I'm running your script with serial_console_untouched=True and main program calls "read" every 10 seconds
Sometimes the scripts runs ok, but other times it returns "None"
image
Can you imagine what's happening?

@UedaTakeyuki
Copy link
Owner

No idea, sorry.

@UedaTakeyuki
Copy link
Owner

UedaTakeyuki commented Mar 25, 2021

Hi iperniaf,

I've marged issue #30 and updated it to version 3.0.2 both github and pypi.
Would you please try it? thank you.

@UedaTakeyuki
Copy link
Owner

longtime no feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants