New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
framer-motion package version not compatible with react-app #104
Comments
Hey @JulienGasparLopes thanks for creating an issue! I have released a new version (2.0.4) where I have changed framer into a peer dependency with both framer v4 and framer v6 and supported. Let me know if it works! |
Wow thx a lot, I really appreciate your reactivity ;) Unfortunately it doesn't seems to fix the problem. I'm guessing this is because the error happens on this file : I made RSI working on my projet by changing framer-motion to |
@JulienGasparLopes thanks for trying it out! The built RSI version does not include node_modules. A fresh module install should resolve to |
I'll try again, I did remove node_modules and package-lock but I must have missed something ! |
Okey I tried again and succeeded ! peerDependencies allows me to select the version I need to install (due to my project stack versions of node and other lib I'm unable to use peerDependency auto-installation but works fine by defining versions I need in dependencies) |
@JulienGasparLopes Awesome! Glad it works! |
I get this error while installing RSI on a brand new react-app (with create react-app) or when installing on an existing project (pure JS, no TS installed) :
Can't import the named export 'Children' from non EcmaScript module (only default export is available)
Reproduction
Node : v16.15.0
package.json :
Possible Solution
I've already seen this PR that proposed a fix by downgrading framer-motion : #93
I tried it by forking project, changing lib version to
4.1.17
and importing on my project the new builded lib. It works perfectlyMore about the error
This is a known issue due to ReactCreateApp not working with ESmodule since version5 :
reactioncommerce/reaction-component-library#399
Downgrading framer-motion doesn't seems to have impact and may allow to easily install RSI (it should be upgraded when RCA fixed this issue)
I'd be glad to discuss it further / to propose a PR :)
PS : thx for this awesome lib, i'm considering to contribute to it ! Cheers !
The text was updated successfully, but these errors were encountered: