Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing "Escape key" while in "discard or keep changes" window will save current changes. I don't think this should be a thing. #15601

Open
2 tasks
Genox666 opened this issue May 24, 2023 · 4 comments
Labels
Status: On Backlog The issue / feature has been reproduced and is deemed important enough to be fixed. Type: Bug The code does not produce the intended behavior.

Comments

@Genox666
Copy link

Application Version

5.3.0

Platform

Windows 10

Printer

Creality Ender-5 Plus

Reproduction steps

  1. Open "Print settings" popup menu at the right.
  2. Change any settings you want to configure.
  3. Click the blue "Compare and save." icon at the top of the menu.
  4. Once you are done looking at the changes you made, press the "Escape key" to close the window.

Actual results

The window is closed and the changes have been saved as if you had clicked on the "Save" button.

Expected results

The window closes and the changes are not saved. Same as manually clicking on the red X in the upper corner of the window.

Image1: Print settings window with a modification to the profile
image

Image2: Discard or keep changes window before pressing escape
image

Image3: Print settings window after pressing escape
image

Checklist of files to include

  • Log file
  • Project file

Additional information & file uploads

There's really not much more to it than previously described.

@Genox666 Genox666 added Status: Triage This ticket requires input from someone of the Cura team Type: Bug The code does not produce the intended behavior. labels May 24, 2023
@MariMakes
Copy link
Contributor

Hey @Genox666,

Welcome to the UltiMaker Cura Github 🚀
Sorry, it took us a while to get back to you 😞

I don't use profiles that often, so I haven't encountered this, but I can reproduce your issue on my side.
Recording #48
But only if I work with custom profiles, not with the default ones.
I agree that it's weird that saving is the default behavior for the escape button in this case. 😮

I'll bring it up to the team to see what they can do to improve it.
But I expect that if it's not a quick fix that it will not get a high priority to implement.
Fingers crossed 🤞

@MariMakes MariMakes added Status: Under Investigation The issue has been confirmed or is assumed to be likely to be a real issue. It's pending discussion. and removed Status: Triage This ticket requires input from someone of the Cura team labels Jun 5, 2023
@Genox666
Copy link
Author

Genox666 commented Jun 5, 2023

Thank you for your reply!
Not a major problem, simply a required adaptation.
Fingers crossed 🤞 indeed.

@MariMakes
Copy link
Contributor

Quick update from our side 👋

We've added a ticket to the backlog with the intent to improve this.
For internal reference CURA-10672

Thanks for the report! 👍

@MariMakes MariMakes added Status: On Backlog The issue / feature has been reproduced and is deemed important enough to be fixed. and removed Status: Under Investigation The issue has been confirmed or is assumed to be likely to be a real issue. It's pending discussion. labels Jun 7, 2023
@Bzzz
Copy link

Bzzz commented Nov 21, 2023

This f*cked me over today big time with a dozen of experimental settings on an otherwise fine profile (and of course no backup) - please fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: On Backlog The issue / feature has been reproduced and is deemed important enough to be fixed. Type: Bug The code does not produce the intended behavior.
Projects
None yet
Development

No branches or pull requests

3 participants