Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember window size #659

Closed
MattKunze opened this issue May 30, 2018 · 4 comments · Fixed by #902
Closed

Remember window size #659

MattKunze opened this issue May 30, 2018 · 4 comments · Fixed by #902
Assignees
Projects

Comments

@MattKunze
Copy link

I have a pretty big monitor (3440x1440) and when starting the agent app it automatically expands to fill the screen (OSX, haven't tried it anywhere else). Having a more reasonable initial size, and potentially remembering the previous layout, would be a lot less jarring

@mondalaci
Copy link
Member

I agree that Agent should always remember the previous window size and state (maximized vs unmaximized).

As for the initial window size, it's less trivial given the wide range of possible resolutions. Any suggestions about the latter?

@MattKunze
Copy link
Author

I think it should be as small as feasible in order to provide access to the basic functionality, it's not like the keyboard image needs to be particularly large to be usable since the keys are relatively large:

screen shot 2018-05-30 at 2 27 03 pm

That wouldn't fit on a 1024x768 screen though (shrinking it any more either loses the title or you have to scroll the body in some cases to access the remap overlay)

I haven't worked with electron much, so not sure what the best practices are there. I would think there have to be some utility modules or something that handle this reasonably by default

@mondalaci
Copy link
Member

Good points, thanks! We'll think about this before implementing it.

@mondalaci
Copy link
Member

Given that Agent looks right on most monitors when maximized, it will start as such by default, but then it'll remember and restore its last window size setting upon startup. We'll only implement this for now.

@mondalaci mondalaci changed the title Don't display fullscreen on initial launch Remember window size Jul 23, 2018
@mondalaci mondalaci added this to Robi in Agent todo Jul 23, 2018
@ert78gb ert78gb moved this from Robi to Under review in Agent todo Jan 23, 2019
Agent todo automation moved this from Under review to Done Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Agent todo
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants