Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Release v1.0.3 Feedback #9

Open
Ultraporing opened this issue May 11, 2021 · 6 comments
Open

Experimental Release v1.0.3 Feedback #9

Ultraporing opened this issue May 11, 2021 · 6 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Ultraporing
Copy link
Owner

Ultraporing commented May 11, 2021

Please post your feedback here as a comment. Thanks.
If it does not work, please look into the data.json and also tell me if the IPs are IP4 or IP6. The path to it is shown when you enable the Firewall rules.
IP4 look like this: xxx.xxx.xxx.xxx
IP6 look like this: xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx

@cdr0y
Copy link

cdr0y commented May 12, 2021

  • Would be useful if you could add in a feature to pull from the custom_ip section of the data.json file as that literally bypasses the entire need to sign up to a website just to store an IP address. (or even better, just get it to read a data.json from the local directory.
  • Doesn't always work, sometimes i get the odd person join my lobby when i'm whitelisting multiple IPs. This might just be down to when the rules should be applied though?
  • I did notice a weird thing; when I look at the IPs set in windows firewall, i noticed that it just applies the IP you give it to the firewall rule, so for the blacklist rule, it's setting my friends IPs in the range, therefore doesn't that apply the blacklist rule to your friends, rather than everyone else? I could probably show you this one a little better on discord as it may just be me misunderstanding how win firewall scope works.
  • would be useful to have a couple of new features like creating a session and an option to just remove the rules.

This one I've had the most success with so far tbh so keep it up :-)

If you need help testing the friends feature, my discord is Sammm#0065

@Ultraporing
Copy link
Owner Author

  • I did notice a weird thing; when I look at the IPs set in windows firewall, i noticed that it just applies the IP you give it to the firewall rule, so for the blacklist rule, it's setting my friends IPs in the range, therefore doesn't that apply the blacklist rule to your friends, rather than everyone else? I could probably show you this one a little better on discord as it may just be me misunderstanding how win firewall scope works.

thanks for reporting, im uploading a quickfix. I forgot to change a line.
here are some infos about WinFirewall and Scope: https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2003/cc776852(v=ws.10)#to-change-the-scope-of-an-exception
here infos about rule precedense: https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-firewall/best-practices-configuring#understand-rule-precedence-for-inbound-rules

@cdr0y
Copy link

cdr0y commented May 17, 2021

if i create a new lobby and then activate it, it kicks them out.
if i create a new lobby and activate it before they join, they can't get in

@Ultraporing
Copy link
Owner Author

if i create a new lobby and then activate it, it kicks them out.
if i create a new lobby and activate it before they join, they can't get in

strange. I'm sick and tired of trying to find the correct FW settings. I'll start soon on a rework to checking and blocking of randoms in realtime. This basically means: The program has to run in the Background while playing, and when it detects a connection on ports "6672,65431" it compares the ip against the whitelist and adds the corresponding non whitelisted ip to the FW rules to be blocked.

@NotRealPaz
Copy link

NotRealPaz commented Jul 24, 2021

  1. Explicitly defined allow rules will take precedence over the default block setting.
  2. Explicit block rules will take precedence over any conflicting allow rules.
  3. More specific rules will take precedence over less specific rules, except in the case of explicit block rules as mentioned in 2. (For example, if the parameters of rule 1 includes an IP address range, while the parameters of rule 2 include a single IP host address, rule 2 will take precedence.)

The above only work on InBound i think.
But in OutBound It alway feel right Block rule takeover the Allow rule.

I already try adding every ip range in the world to blocklist but I hit the limit on FW settings (The array bounds are invalid) dont try this.

please ignore edit history

@NotRealPaz
Copy link

i think this will work https://superuser.com/a/977330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants