-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Regex in module value, function in rename value when selecting module
#54
Comments
Hi. |
Created pull request #55 |
I think we are good to go. I additionally introduced a method to match the module via the raw source. Any final objections? |
I think that's great!! Thanks for the great support and help. The ImportManager dependency needs to be updated whenever you publish that first, though, right? |
Thanks for your contribution. This is a real enhancement. 馃憤
Yes. |
Resolved in #56 |
Thank you very much for all your hard work on this!! So thankful for the quick turnaround and the great improvements. Have a great week! |
Hi! 馃憢
Firstly, thanks for your work on this project! 馃檪
Today I used patch-package to patch
rollup-plugin-import-manager@0.5.3
for the project I'm working on source code for the plugin configuration here.I needed to make exact matches to module names (instead of the current matching where it looks for the config-provided module name anywhere in the module name string) so that I could remove a specific module but not modules whose names included that module name, so I added Regex support in the module name.
I also needed to modify the relative path to modules programmatically when renaming them, not only replace module names one-for-one, so I added the ability to provide a function that receives the full raw module source path and returns a new full raw module source path.
Here is the diff that solved my problem:
This change corresponds to UmamiAppearance/ImportManager#47
Please let me know if you would like me to submit a pull request with these changes.
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: