Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable binary files download during link checking #5

Open
gaurav-nelson opened this issue Sep 25, 2023 · 2 comments
Open

Disable binary files download during link checking #5

gaurav-nelson opened this issue Sep 25, 2023 · 2 comments
Labels
bug Something isn't working hacktoberfest

Comments

@gaurav-nelson
Copy link
Contributor

Currently, Linkspector would download the files if the link point to a PDF file or binary. It should instead only check if the link is valid and not download the file.

@gaurav-nelson gaurav-nelson added bug Something isn't working hacktoberfest labels Sep 25, 2023
@edwarddavidbaker
Copy link

edwarddavidbaker commented Apr 30, 2024

Hi @gaurav-nelson I appreciate all of the effort you put into verifying markdown links. Quick question:

It should instead only check if the link is valid and not download the file.

It is common to link to PDFs for specifications and reference material. Does valid also include checking that the link is live and responding to requests? It is helpful to know if a PDF (or other asset) isn't available anymore and responding with a 404.

@gaurav-nelson
Copy link
Contributor Author

Thank you @edwarddavidbaker Yes, it should check if the link is alive and not 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants