Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOX theme V0.2.2 out of range for filament change screen #1892

Closed
Jack77777777 opened this issue Jun 2, 2021 · 5 comments · Fixed by #1997
Closed

NOX theme V0.2.2 out of range for filament change screen #1892

Jack77777777 opened this issue Jun 2, 2021 · 5 comments · Fixed by #1997
Assignees
Labels
bug Something isn't working

Comments

@Jack77777777
Copy link

@noxhirsch can you adjust this ? See attached picture.
IMG_4090

@Jack77777777 Jack77777777 added the bug Something isn't working label Jun 2, 2021
@noxhirsch
Copy link
Contributor

I'll try to fix it later today or tomorrow 👍

@noxhirsch
Copy link
Contributor

After some trial & error without succes, I checked if this also happens without the NOX theme - and it does indeed.
The way I see it, two changes need to be made in OctoDash, but I have no time to setup a dev instance at the moment, to try that out. In theory, this should fix the problem:

Either the second <span> must be integrated into the first one - or both spans need a wrapper div/span:

<span class="change-filament__filament-weight">
{{ getSpoolWeightLeft(selectedSpool.weight, selectedSpool.used) }}
</span>
<span i18n="@@filament-grams-left">g left</span>

I'd prefer the first solution, if it doesn't cause any problems. But if a wrapper around both spans is used, these styles should be moved to the wrapper:

&-weight {
opacity: 1;
font-size: 1rem;
line-height: 1.5rem;
display: block;
text-align: center;

Then either the wrapper or the two spans need to have display:inline; instead of display:block; (I'm not sure if both works, I would have to try that out)

@UnchartedBull
Copy link
Owner

Oh this must've happened with the i18n integration. I'm going to fix this. Thanks for reporting / providing a fix!

@Jack77777777
Copy link
Author

Is this already fixed ? If yes, what do i have to do ?

@UnchartedBull
Copy link
Owner

Not fixed yet. Will be released with the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants