Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scroll on files // UI increase scroll bar contrast #208

Closed
hessius opened this issue Oct 14, 2019 · 14 comments · Fixed by #233
Closed

Enable scroll on files // UI increase scroll bar contrast #208

hessius opened this issue Oct 14, 2019 · 14 comments · Fixed by #233
Assignees
Labels
bug Something isn't working enhancement New feature or request
Projects

Comments

@hessius
Copy link
Contributor

hessius commented Oct 14, 2019

As title, a small ui change; I thought scrolling the file list was broken because I couldn’t understand the scroll bar, would be good to have a higher contrast element, maybe an outline/border with somewhat higher contrast would be both unobtrusive and clear enough to improve usability.

As a second change maybe up and down scroll buttons for the scroll bar would be good as well (instead of only relying on dragging the scroll bar handle)

(Btw are you using some sort of ui framework or making it up as you go?)

@UnchartedBull
Copy link
Owner

Currently there is only a visible thumb for the scrollbar because I don't like any background for scrollbars (similar to how mac and iPhones handle scrollbars). A outline or something might be worth a look though it may break the current workaround for resizing the scrollbar in height though ...

You normally should be also able to just swipe on the file list, this works at least for me. Some buttons are a good idea though as it can be tricky with a resistive touch to record a smooth sliding motion.

Not using a UI Framework, I've never really found one, that I liked 100% so I though for a small project like OctoDash doing my own stuff should be sufficient.

@UnchartedBull UnchartedBull self-assigned this Oct 14, 2019
@UnchartedBull UnchartedBull added the enhancement New feature or request label Oct 14, 2019
@UnchartedBull UnchartedBull added this to To do in v2 Release via automation Oct 14, 2019
@hessius
Copy link
Contributor Author

hessius commented Oct 14, 2019

Okay, makes sense with the framework (just wanted to know because if so I could poke around that)

I’m not able to swipe on the list to scroll.

Are resistive touch screens able to send the tap hold event reliably?
There are some smooth scrolling libraries, you could bind a tap to a certain scroll length with easing and then bind tap hold to a continuous scroll based on how long the user holds? (Haven’t tried this myself)

@hessius
Copy link
Contributor Author

hessius commented Oct 14, 2019

(I’ve previously used a framework called framework7 which both includes loads of ui components and a DOM manipulation library (which can be used separately, called DOM7) where I think this feature could be built using the built in scrolling functionality, this might all be overkill for this feature though.)

Edit: link - https://framework7.io/

@UnchartedBull
Copy link
Owner

Currently it's just a list with overflow so Chrome takes over the whole scrolling part. Don't know if I can change how Chrome handles that.

Oh ok if also take DOM Frameworks and stuff - I'm using Angular 8, which makes everything a lot easier (two databinding, etc.). I may have a look whether there is a component for that, but having two of these libraries running in parallel good lead to some funky behavior.

@hessius
Copy link
Contributor Author

hessius commented Oct 15, 2019

Yeah I agree it might be overkill, you can however use just the ui component library and roll your own library for the Dom. They have pre made packages integrating vue and react but left angular a few versions ago.

It’s weird that I can’t drag to scroll on the list (that’s what I tried at first), ensuring that works would remove the need for higher contrast, maybe something can be done to improve/enable scrollability...

Maybe https://github.com/cubiq/iscroll could be a good fit, it’s a light weight library with good documentation but unfortunately not maintained as the author retired. That’s more of a work around than a straight up bug fix though.

@UnchartedBull
Copy link
Owner

I have a look at how the scrolling could be improved and may come back to you for testing, if you don't mind :)

@hessius
Copy link
Contributor Author

hessius commented Oct 15, 2019

Yeah absolutely!

@UnchartedBull UnchartedBull moved this from To do to In progress in v2 Release Oct 15, 2019
@UnchartedBull UnchartedBull added the bug Something isn't working label Oct 17, 2019
@UnchartedBull
Copy link
Owner

Ok after some debugging and tinkering around I think I found the issue:

Can it be that you only tried dragging on files? At least on my side the library I use to detect long presses seem to destroy the scroll event. Could you try and scroll to folder and start dragging there and confirm that this works for you?

@hessius
Copy link
Contributor Author

hessius commented Oct 18, 2019

Yeah I've only scrolled on files since I haven't got folders. But just so that I understand, you want me to try dragging on folders instead of files to confirm it's the same behaviour that you found?

@UnchartedBull
Copy link
Owner

You basically have to start scrolling on a folder and then can go over files and stuff. Just the start needs to be one a folder. But I‘m 99% certain, that this is the problem here. I already found a fix for that.

@hessius
Copy link
Contributor Author

hessius commented Oct 18, 2019

Ok, great I recently purged all my old files, I'll add some back after work tonight and try scrolling starting on a folder

@hessius hessius changed the title UI increase scroll bar contrast Enable scroll on files // UI increase scroll bar contrast Oct 18, 2019
@UnchartedBull
Copy link
Owner

Yes that will be great. I'll wait with the merge until you confirm that scrolling on starting on a folder does work :)

@UnchartedBull
Copy link
Owner

I've also included a track for the scrollbar thumb, it looks a bit nicer and cleaner that way :) You can see a small part of it at the very bottom.

files_view

@hessius
Copy link
Contributor Author

hessius commented Oct 18, 2019

I can confirm scrolling on folders is working

v2 Release automation moved this from In progress to Done Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
v2 Release
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants