Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show degrees F for enclosure sensor as an option (if it is configured as such in Enclosure Plugin) #397

Closed
spiff72 opened this issue Feb 1, 2020 · 4 comments · Fixed by #407
Assignees
Labels
enhancement New feature or request
Projects

Comments

@spiff72
Copy link

spiff72 commented Feb 1, 2020

Is your feature request related to a problem? Please describe.
Minor issue - I am using a temperature sensor in my enclosure and just added it to Octodash. I have it configured for degrees F currently (but may switch it to degrees C in the future for consistency with the extruder and bed temperatures). I have this configured in the Enclosure Plugin.

Describe the solution you'd like
I don't know if there is a way to see the configuration of the enclosure plugin temp sensor, but if not, I suspect it could be assumed if the temp is over say 50 degrees, it can probably be assumed that it is degrees F.

This is relatively minor - and I will likely try to switch to degrees C in the future - I just need to figure out what temps to set up in the Enclosure Plugin for the PWM link to temperature.

@spiff72 spiff72 added the enhancement New feature or request label Feb 1, 2020
@UnchartedBull
Copy link
Owner

That's possible. Hopefully there will be some time to spare this weekend to continue work on OctoDash. Leaving this link here for later: https://github.com/vitormhenrique/OctoPrint-Enclosure/blob/master/API.md#list-a-specific-input

@UnchartedBull UnchartedBull self-assigned this Feb 3, 2020
@UnchartedBull UnchartedBull added this to To do in v2 Release via automation Feb 3, 2020
@UnchartedBull UnchartedBull moved this from To do to In progress in v2 Release Feb 3, 2020
@spiff72
Copy link
Author

spiff72 commented Feb 3, 2020

As I mentioned above, this should be low on the list of priorities! I already switched my enclosure plugin to deg C and I am working on some other stuff that will likely require it stays as such. (Using GCODE to set target temp for a temperature sensor control that toggles an exhaust fan). I just need to force myself to get used to deg C! I printed a cheatsheet chart so that should help in that regard. :-)

@UnchartedBull
Copy link
Owner

UnchartedBull commented Feb 4, 2020 via email

@spiff72
Copy link
Author

spiff72 commented Feb 4, 2020

Understood. Someday maybe the US will adopt the metric system too. (And will stop being one of two(?) countries who insist on still using English units)...

v2 Release automation moved this from In progress to Done Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v2 Release
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants